Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Unify FRI configs at 100 bits #1929

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Nashtare
Copy link
Contributor

@Nashtare Nashtare commented Jan 13, 2025

Motivation

Unify all FRI configs to target 100 bits to match the permutation argument (currently targeting 116 vs 100 bits).
Allows to reduce the number of FRI queries for each layer (soundness level obtained as proof_of_work_bits + log_blowup * num_queries, cc ethSTARK paper for instance).

cc @jtguibas what I was sharing on slack

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@jtguibas
Copy link
Contributor

Thanks for making this! We have a V4 release pending right now, we can merge this once that gets it :)

@leruaa leruaa self-assigned this Jan 28, 2025
@leruaa
Copy link
Contributor

leruaa commented Jan 28, 2025

@Nashtare can you please fix CI?

@leruaa leruaa removed their assignment Jan 28, 2025
@Nashtare
Copy link
Contributor Author

Yes I will fix it (though clippy seems unrelated).
Also is this the right target branch?

@leruaa
Copy link
Contributor

leruaa commented Jan 28, 2025

No it's dev

@Nashtare Nashtare changed the base branch from v4.0.0-rc.2 to dev January 28, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants